Skip to content

OCPBUGS-92656: bump openshift-tests-extension to fix klog stdout parsing on 4.22#31349

Merged
stbenjam merged 2 commits into
openshift:release-4.22from
redhat-chai-bot:OCPBUGS-92656-bump-ote-extension-4.22
Jun 30, 2026
Merged

OCPBUGS-92656: bump openshift-tests-extension to fix klog stdout parsing on 4.22#31349
stbenjam merged 2 commits into
openshift:release-4.22from
redhat-chai-bot:OCPBUGS-92656-bump-ote-extension-4.22

Conversation

@redhat-chai-bot

Copy link
Copy Markdown
Contributor

Summary

Bumps github.com/openshift-eng/openshift-tests-extension from v0.0.0-20260127124016-0fed2b824818 to v0.0.0-20260626105913-1f81f3df939a to pick up OTE PR #74.

Problem

PR openshift/cluster-cloud-controller-manager-operator#480 added dualstack test support to the CCM AWS OTE binary. This introduced a framework.LoadConfig() call that initializes klog, which writes INFO lines to stdout. When openshift-tests runs the binary's list subcommand, it expects pure JSON on stdout but gets klog noise — causing invalid character 'I' looking for beginning of value errors.

This breaks metal platform nightly jobs (metal-ipi-ovn-ipv4, metal-ipi-ovn-ipv6) because the OTE binary is extracted and listed on all platforms.

Fix

OTE PR #74 updated openshift-tests-extension to scan for the first { or [ line before unmarshalling JSON, tolerating stdout contamination from klog or other sources. This bump brings that fix to the 4.22 branch of openshift-tests, fixing the issue for all OTE binaries — not just CCM.

Testing

After merging, metal nightly jobs should pass again. The CCM fix-forward PR (openshift/cluster-cloud-controller-manager-operator#482) can be re-tested with /payload-job for metal-ipi-ovn-ipv4 and metal-ipi-ovn-ipv6.

…parsing

Bumps github.com/openshift-eng/openshift-tests-extension from
v0.0.0-20260127124016-0fed2b824818 to v0.0.0-20260626105913-1f81f3df939a.

This includes the fix from OTE PR openshift#74 which makes the JSON parser in
openshift-tests-extension tolerate klog noise on stdout when listing
OTE binary tests (e.g. cloud-controller-manager-aws-tests-ext).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: cd34e36e-145d-4b3d-b0b8-3b406913da32

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mtulio

mtulio commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

/retitle [openshift-4.22] OCPBUGS-92656: bump openshift-tests-extension to fix klog stdout parsing on 4.22

@mtulio

mtulio commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

/assign

@mtulio

mtulio commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ipi-ovn-ipv6

@mtulio

mtulio commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ipi-ovn-ipv6

@openshift-ci

openshift-ci Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

@mtulio: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/638ed9c0-73e4-11f1-9d4e-3d9df9f59fc0-0

@mtulio

mtulio commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

/retitle [openshift-4.22] OCPBUGS-92656: bump openshift-tests-extension to fix klog stdout parsing on 4.22

@openshift-ci openshift-ci Bot changed the title Bug OCPBUGS-92656: bump openshift-tests-extension to fix klog stdout parsing on 4.22 [openshift-4.22] OCPBUGS-92656: bump openshift-tests-extension to fix klog stdout parsing on 4.22 Jun 29, 2026
@mtulio

mtulio commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

/assign

@mtulio

mtulio commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ipi-ovn-ipv4

@openshift-ci

openshift-ci Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

@mtulio: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ipi-ovn-ipv4

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1ae693a0-73f0-11f1-897c-e6569c90f50b-0

@mtulio

mtulio commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

/payload-job-with-prs periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ipi-ovn-ipv4 openshift/cluster-cloud-controller-manager-operator#482

@openshift-ci

openshift-ci Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

@mtulio: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ipi-ovn-ipv4

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e18cf420-73fc-11f1-9177-1dfff53c3a1a-0

…x klog stdout parsing

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@redhat-chai-bot

Copy link
Copy Markdown
Contributor Author

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ipi-ovn-ipv4

@redhat-chai-bot

Copy link
Copy Markdown
Contributor Author

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ipi-ovn-ipv6

@openshift-ci

openshift-ci Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ipi-ovn-ipv4

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/50e06020-7400-11f1-8653-7e56b9c2b530-0

@openshift-ci

openshift-ci Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/50ae53a0-7400-11f1-92b9-d3a7d5befa84-0

@openshift-ci openshift-ci Bot added the vendor-update Touching vendor dir or related files label Jun 29, 2026
@stbenjam

Copy link
Copy Markdown
Member

/lgtm
/backports-risk-assessed
/verified by CI

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jun 30, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@stbenjam: This PR has been marked as verified by CI.

Details

In response to this:

/lgtm
/backports-risk-assessed
/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2026
@stbenjam stbenjam changed the title [openshift-4.22] OCPBUGS-92656: bump openshift-tests-extension to fix klog stdout parsing on 4.22 OCPBUGS-92656: bump openshift-tests-extension to fix klog stdout parsing on 4.22 Jun 30, 2026
@openshift-ci

openshift-ci Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: redhat-chai-bot, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2026
@stbenjam

Copy link
Copy Markdown
Member

I dunno why the jira bot is MIA, but the bug looks correct.

@stbenjam stbenjam added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jun 30, 2026
@stbenjam stbenjam merged commit 2a925e8 into openshift:release-4.22 Jun 30, 2026
7 of 8 checks passed
@openshift-ci-robot

Copy link
Copy Markdown

@redhat-chai-bot: Jira Issue OCPBUGS-92656 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

Details

In response to this:

Summary

Bumps github.com/openshift-eng/openshift-tests-extension from v0.0.0-20260127124016-0fed2b824818 to v0.0.0-20260626105913-1f81f3df939a to pick up OTE PR #74.

Problem

PR openshift/cluster-cloud-controller-manager-operator#480 added dualstack test support to the CCM AWS OTE binary. This introduced a framework.LoadConfig() call that initializes klog, which writes INFO lines to stdout. When openshift-tests runs the binary's list subcommand, it expects pure JSON on stdout but gets klog noise — causing invalid character 'I' looking for beginning of value errors.

This breaks metal platform nightly jobs (metal-ipi-ovn-ipv4, metal-ipi-ovn-ipv6) because the OTE binary is extracted and listed on all platforms.

Fix

OTE PR #74 updated openshift-tests-extension to scan for the first { or [ line before unmarshalling JSON, tolerating stdout contamination from klog or other sources. This bump brings that fix to the 4.22 branch of openshift-tests, fixing the issue for all OTE binaries — not just CCM.

Testing

After merging, metal nightly jobs should pass again. The CCM fix-forward PR (openshift/cluster-cloud-controller-manager-operator#482) can be re-tested with /payload-job for metal-ipi-ovn-ipv4 and metal-ipi-ovn-ipv6.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tthvo

tthvo commented Jun 30, 2026

Copy link
Copy Markdown
Member

/jira refresh

@openshift-ci-robot

Copy link
Copy Markdown

@tthvo: Jira Issue Verification Checks: Jira Issue OCPBUGS-92656
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-92656 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot

Copy link
Copy Markdown
Contributor

Fix included in release 4.22.0-0.nightly-2026-06-30-192322

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.